search

dracula / zsh

🧛🏻‍♂️ Dark theme for ZSH
https://draculatheme.com/zsh
MIT License
267 stars 70 forks source link

Fix git info prompt. #4

Closed pkaleta closed 5 years ago

pkaleta commented 7 years ago

Fix the way the git prompt is displayed. Currently, there's no closing parenthesis, after branch name:

before:

screen shot 2017-01-13 at 3 14 50 pm

after:

screen shot 2017-01-13 at 3 14 14 pm
avalonwilliams commented 5 years ago

I'm not having this problem on my machine. In fact, applying your patch on my machine creates a visual problem for me. prompt Can you give us your .zshrc?

timorunge commented 5 years ago

@pkaleta : Are you using the latest version of the oh-my-zsh and the corresponding git plugin? Or maybe some other like gitfast (which in the background is also just using the git one...).

But:

ZSH_THEME_GIT_PROMPT_SUFFIX=") %{$reset_color%}"

Should be:

ZSH_THEME_GIT_PROMPT_SUFFIX=")%{$reset_color%} "

See the spaces.

Technically, if we're considering the function git_prompt_info from lib/git.zsh the vars are OK.

avalonwilliams commented 5 years ago

@pkaleta Since we added a custom prompt, rather than relying on oh-my-zsh's git function, this issue may be fixed. Can you please attempt to replicate this with the new updates applied?

pkaleta commented 5 years ago

I'm no longer experiencing this issue. Closing.