dracutdevs / dracut

dracut the event driven initramfs infrastructure
https://github.com/dracutdevs/dracut/wiki
GNU General Public License v2.0
598 stars 397 forks source link

docs: set KVERSION for running test suite #2490

Closed bdrung closed 1 year ago

bdrung commented 1 year ago

Changes

Running the test suite in podman will most likely require setting KVERSION because the running Linux kernel version will most likely be different to the kernel version in the container.

Checklist

LaszloGombos commented 1 year ago

My plan is to improve https://github.com/dracutdevs/dracut/blob/master/tools/test-github.sh and document the use of https://github.com/dracutdevs/dracut/blob/master/tools/test-github.sh in docs/HACKING.md.

We should probably rename test-github.sh .

We should probably teach test-github.sh to only set KVERSION is needed (e.g. by detecting containerization).

If there is interest for a quick win in the documentation, I do not mind landing this PR as is.

@bdrung WDYT ?

bdrung commented 1 year ago

The test-github.sh is just another layer of indirection: test-github.sh -> test/Makefile -> test/TEST-$x/Makefile -> test/Makfile.testdir -> ./test.sh. Maybe test/Makefile could set KVERSION depending on what is available.

A quick win for the documentation is useful even when you rework test-github.sh tomorrow.