search

dracutdevs / dracut

dracut the event driven initramfs infrastructure
https://github.com/dracutdevs/dracut/wiki
GNU General Public License v2.0
598 stars 397 forks source link

ci: remove unused packages from Debian container #2491

Open bdrung opened 1 year ago

bdrung commented 1 year ago

Changes

Improve the Debian container:

I tested locally that the changed container still successfully runs the tests that the integration test runs.

Checklist

Fixes #

LaszloGombos commented 1 year ago

The dash package is a required that must be present on all Debian systems.

It is correct that it is not required, but at the same time there is no obvious need for removing it. One of my goals with test containers has been to align them between distributions when that is a reasonable to do so. Listing dash explicitly is not needed currently for Debian based distributions but it is needed for some other distributions (such as Fedora or Arch), so I prefer to keep it fro Debian based distributions as well.

The debhelper and quilt packages are only needed for packaging dracut.

It is correct that it is not required, but at the same time there is no obvious need for removing it. Recently it has been decided that packaging for distributions no longer maintained upstream, however packaging dependencies are still maintained in the distribution containers (e.g. rpm-build for Fedora or OpenSUSE). This is intentional as I think we should make it easy to consume these test containers downstream as well, where packaging might actually happen inside the test container. We should either remove all packaging related packages from all test containers or we should keep all of them. For this however we need to understand how packaging is done for Fedora and OpenSUSE as well.

To make the list of required packages more architecture independent, replace qemu-system-x86 by qemu-kvm in the Debian Docker image.

This is a very useful change. Yes please.

The Debian image uses initramfs-tools for generating the initramfs. Having initramfs-tools installed should not have any effect on running the test suite.

Would you had installed initramfs-tools explicitly if it would not be pulled in by an open bug ? It should not be a goal upstream to make sure that dracut does not conflict with other initramfs generators. We also do not install mkinitcpio on Arch just to make sure that dracut does not conflict with mkinitcpio. BTW, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994492 is now fixed. The fix will not be available in debian:stable for a while but if this is important for the Ubuntu container then perhaps you can make this happen in the ubuntu:latest container.

stale[bot] commented 11 months ago

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.