search

dracutdevs / dracut

dracut the event driven initramfs infrastructure
https://github.com/dracutdevs/dracut/wiki
GNU General Public License v2.0
598 stars 397 forks source link

ci: fix shellcheck warning SC2319 #2501

Closed Henrik66 closed 5 months ago

Henrik66 commented 1 year ago

fix shellcheck warning SC2319

LaszloGombos commented 1 year ago

@pvalena Thanks for the the reviews.

You seem to indicate that this PR can only be landed by making massive changes all in one PR. Massive PRs like that do not get reviews for months. We can all point to a few PRs that are good but too big to review.

what is the reason to disable this?

So that we can incrementally improve the code in reviewable increments. Making progress on this is blocked for about half year - see https://github.com/dracutdevs/dracut/pull/2272 . At least this PR allows us to make progress and understand our current issues.

stale[bot] commented 11 months ago

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

Henrik66 commented 10 months ago

Given the help from https://github.com/dracutdevs/dracut/pull/2530 I removed the changes related to shellcheck version changes and just kept the code changes regarding SC2319 . Thanks @pvalena for your help with the reviews.