search

dracutdevs / dracut

dracut the event driven initramfs infrastructure
https://github.com/dracutdevs/dracut/wiki
GNU General Public License v2.0
597 stars 396 forks source link

docs: update NEWS.md and AUTHORS #2509

Closed Henrik66 closed 10 months ago

Henrik66 commented 12 months ago

Release 60 commit generated from https://github.com/dracutdevs/dracut/commit/b2af8c8bcfc72802e02e2c0adc2eed9279101624.

The commit is generated using the script from https://github.com/dracutdevs/dracut/pull/2473

stale[bot] commented 10 months ago

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

pvalena commented 10 months ago

Otherwise LGTM.

aafeijoo-suse commented 10 months ago

A release commit without an actual release is kind of weird... and even weirder without having been approved by everyone involved. Sorry, but I'm not going to support this approach.

LaszloGombos commented 10 months ago

A release commit without an actual release is kind of weird... and even weirder without having been approved by everyone involved. Sorry, but I'm not going to support this approach.

Thanks @aafeijoo-suse for your feedback.

Release commit has been always separate from the actual tagging (signing and release) itself (Github release tool is not able to make the release commit).

Please feel free to reach out to admins to tag the commit. I see this commit nothing more than saving time for project admins, so that it is easier for project admins to tag the release.

Not all tagged releases will be taken by distributions (tag 058 is such an example), and some distributions will take commits between tagged releases.

aafeijoo-suse commented 10 months ago

Please feel free to reach out to admins to tag the commit.

Wow... amazing answer.

I see this commit nothing more than saving time for project admins, so that it is easier for project admins to tag the release.

Saving what? How long does it take for an admin to click the merge button if they want to?

Not all releases will be taken by distributions (Github release v58 is such an example), and some distributions will take commits between releases.

058 had a mistake, NEWS.md was not updated, 059 only added that correction on top. You know it and you use it as an excuse? For me what you did with this "merge commit" is just wrong. And I have nothing else to say.

Henrik66 commented 10 months ago

I want to take this PR as an opportunity to thank my mentor @LaszloGombos and other code reviewers especially @aafeijoo-suse who helped me to learn about the project, collaboration with git, shell scripting and Linux boot process.

I hope my code contribution helps to maintain the project and helps to move Linux forward.