search

dracutdevs / dracut

dracut the event driven initramfs infrastructure
https://github.com/dracutdevs/dracut/wiki
GNU General Public License v2.0
597 stars 396 forks source link

test: disable multipath for test 3,13,14 #2542

Closed Henrik66 closed 4 months ago

Henrik66 commented 10 months ago

Fixes #2353

aafeijoo-suse commented 10 months ago

Why not just #2499?

LaszloGombos commented 10 months ago

Why not just #2499?

CC @mwilck

The difference between https://github.com/dracutdevs/dracut/pull/2499 and https://github.com/dracutdevs/dracut/pull/2542 is that https://github.com/dracutdevs/dracut/pull/2542 provides more test coverage.

The purpose of tests is not just to pass them and make the bot green but to actually test the functionality of dracut and dracut modules.

I am suprised to see that openSUSE does not have an interest to test multipath here upstream. With this PR at least some test (e.g. test 02) includes multipath when the test runs.

mwilck commented 10 months ago

I am suprised to see that openSUSE does not have an interest to test multipath here upstream

We do. It's a matter of having the resources to debug these non-trivial issues.

LaszloGombos commented 10 months ago

I am suprised to see that openSUSE does not have an interest to test multipath here upstream

We do. It's a matter of having the resources to debug these non-trivial issues.

@mwilck . Thanks. Sorry I should have been more specific. Do you have a preference which PR we should land here upstream ?

https://github.com/dracutdevs/dracut/pull/2542 or https://github.com/dracutdevs/dracut/pull/2499

mwilck commented 10 months ago

@aafeijoo-suse has voted for #2499 above. That's fine with me. I chatted with him a few hours ago. We will try to figure out jointly what's going on, but that will take time. I guess we can "revert the revert" any time for debugging.

My own main problem is that I don't understand the dracut CI setup well (or not at all, to be precise). I wonder if we can assume that if the test cases complete successfully in a local environment, they will also succeed on GitHub when the tests are re-enabled? AFAIR, the github CI fails if it's run in forks of this repository.

IOW, I need help with getting a setup where I can experiment with the test runs and be sure (to the extent possible) that the results will match the official CI in this repository.

LaszloGombos commented 10 months ago

@aafeijoo-suse has voted for #2499 above. That's fine with me.

Okay, thats also fine with me as well, but https://github.com/dracutdevs/dracut/pull/2542 has additional benefits..

For now I will also approve #2499, even though we only need one or the other.

I need help with getting a setup where I can experiment with the test runs and be sure

https://github.com/dracutdevs/dracut/wiki/Dracut-development#running-tests-with-docker

Of course if #2499 lands, than you will no longer be able to use the upstream openSUSE test container to reproduce the issue without finding a way to create and build your own version of the container. With #2542 you will be able to reproduce the issue without building your own container just by changing the test case itself.