search

dracutdevs / dracut

dracut the event driven initramfs infrastructure
https://github.com/dracutdevs/dracut/wiki
GNU General Public License v2.0
597 stars 396 forks source link

test: skip test 50,60 if ifcfg dracut module can not be installed #2543

Closed Henrik66 closed 4 months ago

Henrik66 commented 10 months ago

Test 50 and 60 have a dependency on the ifcfg dracut module. If ifcfg dracut module is not available, than the preconditions for these tests are not met.

Since ifcfg dracut module is not available in many Linux enviroments (such as Arch or Debian), it make sense to explicitelly skip these tests instead of failing them as they are simply not applicable to many Linux distributions in their current form.

bdrung commented 10 months ago

Please provide a reasoning in the git commit. At least these tests were failing on Debian/Ubuntu (see also bug #2328).

Henrik66 commented 10 months ago

@bdrung Thanks for the review. I added more reasoning to the git commit message.

test: skip test 50,60 if ifcfg dracut module can not be installed

Test 50 and 60 have a dependency on the ifcfg dracut module.
If ifcfg dracut module is not available, than the preconditions
for these tests are not met.

Since ifcfg dracut module is not available in many Linux enviroments
(such as Arch or Debian), it make sense to explicitelly skip these
tests instead of failing them as they are simply not applicable
to many Linux distributions in their current form.

As to your question, these tests are only meant to run if ifcfg dracut module is supported. A better solution would be to reimplement these tests so that they do not require ifcfg dracut module. I am not able to provide such a solution at this time, so until than perhaps we can just skip the test.

bdrung commented 10 months ago

@bdrung Thanks for the review. I added more reasoning to the git commit message.

Thanks.

As to your question, these tests are only meant to run if ifcfg dracut module is supported. A better solution would be to reimplement these tests so that they do not require ifcfg dracut module. I am not able to provide such a solution at this time, so until than perhaps we can just skip the test.

That information could go into the commit message as well, saying something like: Instead of disabling the test, they should be reimplement so that they do not require ifcfg dracut module in the future.

Henrik66 commented 10 months ago

That information could go into the commit message as well, saying something like: Instead of disabling the test, they should be reimplement so that they do not require ifcfg dracut module in the future.

okay. I updated the commit message. Thanks @bdrung