search

dracutdevs / dracut

dracut the event driven initramfs infrastructure
https://github.com/dracutdevs/dracut/wiki
GNU General Public License v2.0
597 stars 396 forks source link

fix: wait 12 hours before halt on media check fail #2545

Open AdamWill opened 10 months ago

AdamWill commented 10 months ago

If a modesetting driver has been loaded by the time the media check happens, halting the system (as we currently do immediately if the check fails) blanks the screen, which is confusing for the user. This adds a warning message and a 12-hour wait before the system is eventually halted, so the user can see the media check failure and (presumably) reboot and fix the medium.

It also tweaks the text of the failure message not to call it a "CD check", since it's not 1998 any more.

https://bugzilla.redhat.com/show_bug.cgi?id=2246410

Checklist

AdamWill commented 10 months ago

Note, this fixes the problem for live images. Traditional installer images use a different codepath that lives in anaconda, I will send a PR for anaconda to fix the same problem on that path.

LaszloGombos commented 10 months ago

This magic number (12 hours) does not make sense to me. How is waiting this long improves the situation for the user ?

Also, https://github.com/dracutdevs/dracut/pull/2332 somewhat related, especially the following point..

For some remote/unattended setup this could even damage the HW.. perhaps poweroff at least safer for the HW.

initramfs images usually not configured for proper power management - e.g. on a laptop this might be fan blasting full speed for a half day.

AdamWill commented 10 months ago

the situation we're concerned about is that the user starts the media check and wanders off to do something else. we want them to come back to a useful error message, not a mysterious blank screen (or, with 2332, powered-off system).

I considered various values from a minute upwards. 12 hours was nirik's suggestion.

AdamWill commented 10 months ago

As for the "unattended" case - presumably, if you choose to run the media check, you're in a position to power off the system after noticing it failed.

AdamWill commented 10 months ago

btw, I wasn't necessarily expecting this to be merged as-is, I was hoping someone had a better idea somehow. But I thought it was good enough for F39 at least, and wanted to submit it upstream before doing the downstream build.

LaszloGombos commented 5 months ago

We also have "rd.debug" in our toolbox. I think dracut already recommends setting "rd.debug" to debug dracut issues for the NOT unattended case.

Users should not just reboot and try again. They should reboot set "rd.debug" in the bootloader and try again instead.

Perhaps if "rd.debug" is NOT set, poweroff is still the best possible action (with not much of a wait). If and only if "rd.debug" is set, having a long timeout (or even waiting for input before taking an action) is very reasonable.

Crossposted also at https://github.com/dracutdevs/dracut/pull/2332 .