draeger-lab / C_striatum_GEMs

This repository contains all changes made to the strain specific models of Corynebacterium striatum.
MIT License
1 stars 0 forks source link

Update FROG reports to later version of cobrapy #8

Closed famosab closed 5 months ago

famosab commented 5 months ago

During the curation we found a small problem with the FROG reports that were submitted for Biomodels MODEL2304270001 to MODEL2304270005 (all 5 related to the Corynebacterium striatum model publication).

In essence, the reports were executed with an older CobraPy and Cameo (before we unified the format of 02_fva.tsv). The model seems reproducible but all comparison tools will give some errors unnecessarily, because the older Cobrapy version uses the "flux" column for the "flux through objective" instead for "flux through the reaction".

If you had a bit of time, could you please submit FROG reports generated with the latest Cobrapy version? This is probably not required to have the curation successful (everything is perfectly OK so the fluxes must be OK as well, and thus the model is fully reproducible), but it would be great to have this fixed eventually for completeness.

The new reports will be created with https://fbc-model-tests.lcsb.uni.lu/.

@GwennyGit You should be able to submit them afterwards.

famosab commented 5 months ago

First file for KCNa01 see commit cb10ff6.

famosab commented 5 months ago

@GwennyGit done