search

draeger-lab / SBSCL

The Systems Biology Simulation Core Library (SBSCL) provides an efficient and exhaustive Java implementation of methods to interpret the content of models encoded in the Systems Biology Markup Language (SBML) and its numerical solution.
https://draeger-lab.github.io/SBSCL/
GNU Lesser General Public License v3.0
20 stars 13 forks source link

Comp example file missing #25

Closed shalinshah1993 closed 6 years ago

shalinshah1993 commented 6 years ago

From @matthiaskoenig on June 11, 2018 10:37

@shalinshah1993 Can you put the comp file with which you tested your comp code in /src/test/resources/comp/?

I cannot find this anywhere in the repository.

Copied from original issue: shalinshah1993/SBSCL#27

shalinshah1993 commented 6 years ago

I used CompExample.java as a test file for hierarchical models. I think you moved that file to src/main/java/ folder when you moved examples folder from test to main. Currently, this is where the file resides:

https://github.com/shalinshah1993/SBSCL/tree/working-branch/src/main/java/org/simulator/examples

You want me to move it or leave it for now since other test files that I used are all in the examples folder? I think we decided to work on them for now and then later move them to src/test/java.

shalinshah1993 commented 6 years ago

From @matthiaskoenig on June 11, 2018 16:23

@shalinshah1993 I need the model you use. Can you upload the SBML comp model. Test and example code is clear.

shalinshah1993 commented 6 years ago

Good point! I used all the test files found here in the comp jsbml commit: https://github.com/sbmlteam/jsbml/commit/46ca561edbca85a1f05f14dcc6e08acd65b2e235

I don't think we want to push all the test files. Maybe we can add test 1 and test 2?