draeger-lab / SBSCL

The Systems Biology Simulation Core Library (SBSCL) provides an efficient and exhaustive Java implementation of methods to interpret the content of models encoded in the Systems Biology Markup Language (SBML) and its numerical solution.
https://draeger-lab.github.io/SBSCL/
GNU Lesser General Public License v3.0
20 stars 13 forks source link

update COBRAsolver to add weighted constraints #30

Closed hemilpanchiwala closed 4 years ago

hemilpanchiwala commented 4 years ago

In COBRAsolver class, when any reactant is just involved in a single reaction, then there should be no weight constraint for it.

This pull request solves this issue by adding the condition to add the weight constraint when the reactant is involved in more than one reaction.

hemilpanchiwala commented 4 years ago

Thanks for doing this fix! According to Travis there is now a build error. Do you know where this is coming from?

@draeger, this error is occurring due to some bug in the CompSimulator. The test files for comp are not executing successfully.

The error message in the image occurs while running the simulation for src/test/resources/comp/test6.xml

Similar error is for test7.xml to test10.xml files.