Fewer BigDecimal conversions

draeger-lab / SBSCL

The Systems Biology Simulation Core Library (SBSCL) provides an efficient and exhaustive Java implementation of methods to interpret the content of models encoded in the Systems Biology Markup Language (SBML) and its numerical solution.

https://draeger-lab.github.io/SBSCL/

GNU Lesser General Public License v3.0

20 stars 13 forks source link

Fewer BigDecimal conversions #60

Closed curiousleo closed 3 years ago

curiousleo commented 3 years ago

I took a look at the tests with perf and saw that a bunch of time was spent in BigDecimal conversions. At least those in the hot loop seem unnecessary, so I removed them.

draeger commented 3 years ago

@curiousleo: Travis reports that the build fails after the changes to the download script.

curiousleo commented 3 years ago

@curiousleo: Travis reports that the build fails after the changes to the download script.

Oops, I had no intention of breaking your build!

master is green after #59 was merged
this PR's branch is green (and CI runs about a minute faster!)

Could you point me to the failure you're seeing after the download script changes?