Draft-Js dependency incorrect?

draft-js-plugins / draft-js-plugins

React Plugin Architecture for Draft.js including Slack-Like Emojis, FB-Like Mentions and Stickers

https://www.draft-js-plugins.com/

MIT License

4.09k stars 1.06k forks source link

Draft-Js dependency incorrect? #702

Closed marekolszewski closed 7 years ago

marekolszewski commented 7 years ago

Since 3ba2d3, I believe the draft-js dependency in each plugins' package.json file should have been bumped to v0.10.0. I just ran into a bunch of issues because the resizable plugin was pulling in an older version of draft js but calling the new getEntity function.

Related to this, it may make sense to move the draft-js dependency into peerDependencies in each of the plugins.

melbourne2991 commented 7 years ago

+1 for making it a peer dependency if possible. If not then draftjs-plugins-editor should probably export RichUtils, EditorState etc. Otherwise I might be developing my own custom plugin with a newer/older version of RichUtils (using rich utils as an example but could be anything from core draftjs) that's incompatible with what draftjs-plugins uses internally.

nikgraf commented 7 years ago

Sounds good to me. Interested to create a PR?