search

draftbox-co / gatsby-ghost-novela-theme

A Feature rich Gatsby theme plugin for creating blogs from Ghost.
https://ghost-novela-preview.draftbox.co/
12 stars 8 forks source link

Error in figure handler #7

Open jlev opened 4 years ago

jlev commented 4 years ago

I'm using this theme to self-host a blog with data from ghost on netlify via gatsby. It seems that it breaks if there is a ghost "bookmark" without a description. It's failing at https://github.com/draftbox-co/gatsby-ghost-novela-theme/blob/d0324cc7c8dcb966a4601b2e7321857062e3e4f7/gatsby-ghost-novela-theme/src/utils/handlers.js#L56

Because the node has no children, this causes TypeError: Cannot read property 'value' of undefined. I haven't been able to override this function, because it's not called with the @ style like most of the other components.

Can this be coded more defensively, so it checks for the node's children before calling for the first one? Ideally this wouldn't happen, but this link has a blank meta description tag, and it's not editable in ghost.

thandaanda commented 3 years ago

Hi @jlev ,

Thanks for bringing this to our notice. Currently, we are swamped with new feature requests. However, we would definitely welcome a PR, and if you have any questions let us know!