_WinHttpSimpleSSLRequest fails on some OS / website combinations

dragana-r / autoit-winhttp

Automatically exported from code.google.com/p/autoit-winhttp

70 stars 20 forks source link

_WinHttpSimpleSSLRequest fails on some OS / website combinations #13

Closed Danp2 closed 4 years ago

Danp2 commented 4 years ago

To reproduce, run example script _WinHttpSimpleSSLRequest under Window Server 2016.

See https://github.com/Danp2/WebDriver/issues/40 for further details.

dragana-r commented 4 years ago

GitHub forces TLS1.2. It appears that WinHTTP doesn't advertise TLS flavor during handshake on such systems when SSL2 is specified even if supported. That also means that systems with this issue are updated because they shouldn't have TLS1.2 by default. I've made addition to _WinHttpSimpleSendSSLRequest where this situation is detected and responded to. It should be backward compatible. @Danp2 could you try the code by any chance, if you still have access to such systems?

Danp2 commented 4 years ago

Appears to work correctly to me. Thanks!