Define firmware version minor for payload in version.h

dragino / LGT-92_-LoRa_GPS_Tracker

Software Source code for LoRa_GPS_Tracker

51 stars 42 forks source link

Define firmware version minor for payload in version.h #31

Closed tormodvolden closed 2 years ago

tormodvolden commented 2 years ago

Fixes #28

marcelstoer commented 2 years ago

Thanks for this fix!

To improve things even more and to reduce the risk of someone forgetting to bump the version in all the required places maybe you could define:

FIRMWARE_VERSION_MAJOR, FIRMWARE_VERSION_MINOR, and FIRMWARE_VERSION_PATCH in version.h
make #define AT_VERSION_STRING in version.h use these three defines (rather than re-defining it)
use these defines for https://github.com/dragino/LGT-92_-LoRa_GPS_Tracker/blob/master/Projects/Multi/Applications/LoRa/DRAGINO-LRWAN(AT)/src/lora.c#L122 as well
use these defines in all the other places I forgot (i.e. didn't find)...

marcelstoer commented 2 years ago

@tormodvolden did you find instructions somewhere how to build this thing? I am a little surprised they don't have a CI process hooked up to this repository.

tormodvolden commented 2 years ago

@marcelstoer It is not so surprising given that it has been built with a proprietary GUI IDE (I don't know the terms of use and details, I never used it), and this github repository is not where it is being developed and maintained, but more a place to publish it.

Build instructions can be found in the user manual, chapter 5 "Developer Guide" and seem well described.

marcelstoer commented 2 years ago

this github repository is not where it is being developed and maintained

I see...actually suspected so. However, I must assume @dragino has a process in place to sync the changes here back to the internal (i.e. real) source. It would otherwise not make much sense even accepting PRs.

proprietary GUI IDE (I don't know the terms of use and details, I never used it)

I can't see myself using that either. Your recent addition of GCC support will at least allow me to ensure that whatever I change will actually compile 😜 Thought about taking a stab at implementing the changes I suggested earlier in https://github.com/dragino/LGT-92_-LoRa_GPS_Tracker/pull/31#issuecomment-970199410

tormodvolden commented 2 years ago

About the GCC support: We should add a README with a big fat warning that if you simply flash your LGT-92 with the result of the build, it will wipe out the flash settings with LORA IDs and keys etc. Maybe the Makefile flash target should check that there are flash settings at the new, higher location before proceeding to flash the firmware.