dragomano / Optimus

A simple SEO mod for SMF
https://custom.simplemachines.org/mods/index.php?mod=2659
Artistic License 2.0
6 stars 8 forks source link

PHP 7.4 error #32

Closed radu81 closed 3 years ago

radu81 commented 3 years ago

I am using this add-on on Elkarte 1.1.6 and I am doing some tests with PHP 7.4, after every page refresh I get this error on Elkarte log: Type of error: General Unknown Error: implode(): Passing glue string after array is deprecated. Swap the parameters /index.php?action=mentions;sa=fetch;api=json;lastsent=0 File: /public/sources/subs/Optimus.class.php Line: 290

289: | if (!empty($list_item)) 290: | $context['insert_after_template'] .= implode($list_item, ','); 291: |   292: | $context['insert_after_template'] .= ']

Is there any way to fix this? Thank you in advance

dragomano commented 3 years ago

Thanks, I will release a fix soon.

radu81 commented 3 years ago

Thank you dragomano. In the meantime Spuds found a solution, change line 290 with $context['insert_after_template'] .= implode(',', $list_item);