upstream error

[dragondaud]

A commit to Arduino/ESP8266 yesterday breaks functionality of myClock. I would advise not updating your ESP core until they fix this upstream, but if you already broke your clock, you can try this:

cd ~/Arduino/hardware/esp8266com/esp8266
git checkout 2eb5b5600a3631cdfb9ddd1150505d82e38f3406

Then compile and upload over serial, as the bug seems to break OTA, too.

[dragondaud]

I have verified the upstream fix corrects this issue. To return the ESP core to latest:

git checkout HEAD
git pull

[dragondaud]

Nevermind, still an issue. Reverting back as described above fixes submit issues.

[hallard]

@dragondaud do you know what's the issue ?

[dragondaud]

They made some changes to argument parsing in httpserver that I believe broke something. I haven't had time to look into the specifics. They also changed another bit that broke stuff, which was the original problem I opened this issue over, but it was reverted, and that is when I discovered the arg parsing issue.

[dragondaud]

There is a PR that fixes this issue, it has not yet been merged, but seems to fix the problem. From esp8266 directory, run these commands:

git checkout HEAD
git pull
git fetch origin pull/5262/head:fixparse
git checkout fixparse

Then rebuild myClock. After this PR is merged, you can return to master.

[dragondaud]

PR#6262 has been merged into master, go back with:

git checkout master
git pull
git branch -D fixparse

[tribblon]

yay!

On Wed, Oct 24, 2018 at 2:47 PM daud notifications@github.com wrote:

PR#6262 has been merged into master, go back with:

git checkout master git pull git branch -d fixparse

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dragondaud/myClock/issues/4#issuecomment-432822277, or mute the thread https://github.com/notifications/unsubscribe-auth/APay4JvgFIFzIriPynLrPpIP5kPq7bcDks5uoNH4gaJpZM4XvKZQ .

-- Regards, Paul Schiro tribblon@gmail.com 720.280.7023