search

dragonexpert / Trade-Feedback

A trade feedback system for MyBB.
4 stars 2 forks source link

SQL error on tradefeedback.php #31

Closed leefish closed 9 years ago

leefish commented 9 years ago

If the trader plugin is uninstalled then visiting the tradefeedback url gives an SQL error (table does not exist).

dragonexpert commented 9 years ago

I guess the best way is to use the error function.

andrewjs18 commented 9 years ago

if I deactivate, uninstall trade feedback and then try visiting a trader feedback link, the page is white and it logs the following error:

[Sat Jul 25 17:49:13 2015] [error] [client IP] FastCGI: server "/home/www-data/web/php-fastcgi" stderr: PHP Fatal error: Call to undefined function trader_is_installed() in /public_html/18/tradefeedback.php on line 6, referer: http://andrewshemo.com/18/tradefeedback.php

dragonexpert commented 9 years ago

I thought it loaded all plugin files in global.php. Easy fix though.

dragonexpert commented 9 years ago

Should be fixed now.

andrewjs18 commented 9 years ago

retested again. this is the error it'll show:

Trade Feedback is not installed.

no errors in my log.

dragonexpert commented 9 years ago

That is the intended behavior if Trade Feedback is not installed.

andrewjs18 commented 9 years ago

I figured. I'd consider it fixed then.