dragonfly-science / bailiwick-ui

Bailiwick frontend
1 stars 1 forks source link

Over/Under chart? #27

Closed simonwinter closed 5 years ago

simonwinter commented 5 years ago

In http://webrear.mbie.govt.nz/theme/school-leavers-by-ncea-level/map/over-under-barchart/2016/new-zealand/ncea-level-1?left-transform=regionalPercentage&right-transform=percentage we see a different bar chart type.

Does this need to be included as well?

simonwinter commented 5 years ago

@finlay The Indicator Numbers don't appear to be passed in the IndicatorChartState in the indicatorChart of IndicatorCHart.hs

simonwinter commented 5 years ago

I think this may be related to #25 - at the start of the data in school-leavers-by-ncea-level.json we have this at the start of the numbers:

"numbers": [
        {
            "headline": "    NA",
            "local": "...",
            "national": "  NA",
            "indexDisp": " NA"
        },
...

Which is yielding this error:

getIndicatorDataResponse failure: Error in $.numbers: key "areaid" not present
simonwinter commented 5 years ago

@finlay I've started to change the format of Indicators > IndicatorCharts. However, I need a some help to get them formatted into a jsobject to send to javascript.

see - d4a8e3c597