dragonflydb / dragonfly-operator

A Kubernetes operator to install and manage Dragonfly instances.
https://www.dragonflydb.io/docs/managing-dragonfly/operator/installation
Apache License 2.0
132 stars 28 forks source link

Ability to configure service name #178

Closed 34fathombelow closed 4 months ago

34fathombelow commented 5 months ago

It would be awesome if we could define the name of the service. Currently the service name is created statically by the name defined in the Dragonfly CR. Being able to customize the service name could be very helpful and speed up a migration of an existing Redis service.

If accepted it would make sense to add it to the serviceSpec field.

serviceSpec: name: dragonfly-us-west-1

Pothulapati commented 4 months ago

Being able to customize the service name could be very helpful and speed up a migration of an existing Redis service.

Can you explain more on this? We can add a field but I think a better solution is to actually understand how this specifically helps with migrations.

Thanks.

34fathombelow commented 4 months ago

Thank you for your swift response and eagerness to help out.

Can you explain more on this? We can add a field but I think a better solution is to actually understand how this specifically helps with migrations.

Certain applications like Argo CD predefine an existing service name to use. This can be customized but using an existing name could help a migration. Also certain ingress controllers require a service name for a route. Rather than changing the existing name before a migration is complete a user could use an existing service name.