dragonflydb / dragonfly-operator

A Kubernetes operator to install and manage Dragonfly instances.
https://www.dragonflydb.io/docs/managing-dragonfly/operator/installation
Apache License 2.0
142 stars 33 forks source link

Add `imagePullSecrets` support for Custom Resources #197

Open jurim76 opened 5 months ago

jurim76 commented 5 months ago

CRD supports image value only with predefined external registry. Sometimes access to registry is restricted to internal registry only, in this case you need to define imagePullSecrets or modify serviceAccount.

Aym3nTN commented 4 months ago

@jurim76 Can you provide more details? I'd like to help on this one

jurim76 commented 3 months ago

CR should support imagePullSecrets directive

For example Define in CR yaml

image: "some.local.repo/dragonfly:v1.20.1"
imagePullSecrets:
  - name: regcred

The image will be pulled from some.local.repo, using "regcred" secret

artsenko-cyco commented 3 months ago

hi @Aym3nTN any ETA?

mircea-pavel-anton commented 1 month ago

I am also currently blocked by this, unable to even deploy an instance in my cluster since images from public repositories are not allowed...

@Aym3nTN Can I provide any assistance on this? Are you still working on it?

Aym3nTN commented 1 month ago

@mircea-pavel-anton I hadn't make significant progress. Feel free to work on it.

mircea-pavel-anton commented 1 month ago

I'll see if I can get something going sometime later next week!