search

dragonflydb / dragonfly-operator

A Kubernetes operator to install and manage Dragonfly instances.
https://www.dragonflydb.io/docs/managing-dragonfly/operator/installation
Apache License 2.0
132 stars 28 forks source link

fix(helm): indentation for ServiceMonitor relabelings and metricRelab… #228

Closed nlamirault closed 1 month ago

nlamirault commented 1 month ago

try to generate manifests:

helm template . --set serviceMonitor.enabled=true --debug

before:

kind: ServiceMonitor
metadata:
  labels:
    helm.sh/chart: dragonfly-operator-v1.1.6
    app.kubernetes.io/name: dragonfly-operator
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "v1.1.6"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/created-by: dragonfly-operator
    app.kubernetes.io/part-of: dragonfly-operator
    app.kubernetes.io/component: controller-manager-metrics
  name: release-name-dragonfly-operator-controller-manager-metrics
spec:
  endpoints:
  - targetPort: 8443
    interval: 30s
    scrapeTimeout: 10s
    relabelings:
          - action: replace
        replacement: dev-cluster
        targetLabel: cluster
    metricRelabelings:
          - action: replace
        replacement: dev-cluster
        targetLabel: cluster
  jobLabel: release-name-dragonfly-operator
  namespaceSelector:
    matchNames:
    - default
  selector:
    matchLabels:
      app.kubernetes.io/name: dragonfly-operator
      app.kubernetes.io/instance: release-name

with this PR:

kind: ServiceMonitor
metadata:
  labels:
    helm.sh/chart: dragonfly-operator-v1.1.6
    app.kubernetes.io/name: dragonfly-operator
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "v1.1.6"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/created-by: dragonfly-operator
    app.kubernetes.io/part-of: dragonfly-operator
    app.kubernetes.io/component: controller-manager-metrics
  name: release-name-dragonfly-operator-controller-manager-metrics
spec:
  endpoints:
  - targetPort: 8443
    interval: 30s
    scrapeTimeout: 10s
    relabelings:
    - action: replace
      replacement: dev-cluster
      targetLabel: cluster
    metricRelabelings:
    - action: replace
      replacement: dev-cluster
      targetLabel: cluster
  jobLabel: release-name-dragonfly-operator
  namespaceSelector:
    matchNames:
    - default
  selector:
    matchLabels:
      app.kubernetes.io/name: dragonfly-operator
      app.kubernetes.io/instance: release-name