dragonflydb / dragonfly-operator

A Kubernetes operator to install and manage Dragonfly instances.
https://www.dragonflydb.io/docs/managing-dragonfly/operator/installation
Apache License 2.0
144 stars 34 forks source link

resource: Add a way for the user to set redis password #50

Closed Pothulapati closed 11 months ago

Pothulapati commented 1 year ago

Allow users to set a password for their dragonfly instance through a secret. We should have to use the same secret from the Operator to run commands.

Pothulapati commented 1 year ago

With #57, We will have a way but its not as secret anymore. We should allow a way for user to specify an existing secret in cluster and we should attach that into the Dragonfly pod.

@ashotland Can we somehow specify Dragonfly to read its password from a file?

laurivosandi commented 1 year ago

Make it possible to specify not only secret name but also the key inside the secret

Better yet have the operator populate the secret with various usable structures including the Redis URI

timtorChen commented 1 year ago

How about supporting env and envFrom in Dragonfly CR? As setting up environment DFLY_PASSWORD is now possible https://github.com/dragonflydb/dragonfly/pull/792.

chakaz commented 1 year ago

I can think of 2 ways to specify the password outside of the direct command line arguments

ksingh-scogo commented 1 year ago

👀 much needed feature to use dragonfly that is deployed using operator in production setup

tekumara commented 11 months ago

See https://www.dragonflydb.io/docs/managing-dragonfly/operator/authentication

chakaz commented 11 months ago

For those interested in setting flags using environment variables, we recently added such support. See here for more details, but tl;dr is use DFLY_flag as env var and you should be good to go

Pothulapati commented 11 months ago

Closing this as we support this through a secret now: https://www.dragonflydb.io/docs/managing-dragonfly/operator/authentication#password-based-authentication

Also, With args filed any extra number of configurations can also be passed.