dragonflydb / dragonfly-operator

A Kubernetes operator to install and manage Dragonfly instances.
https://www.dragonflydb.io/docs/managing-dragonfly/operator/installation
Apache License 2.0
132 stars 28 forks source link

Prometheus and Grafana Integration #72

Closed ionfury closed 9 months ago

ionfury commented 1 year ago

It would be great if the operator included or provisioned resources to integrate with Prometheus and Grafana out of the box. Specifically, creating the following resources would be very helpful:

Pothulapati commented 1 year ago

This is a valid feature request @ionfury! Don't have a timeline for it yet but might work on it next week! Meanwhile, feel free to raise a PR if you want/can!

hermanbanken commented 1 year ago

Plus one here too. We use DataDog with OpenMetrics so this means that the Pod instance that runs DragonflyDB should have certain DataDog-specific annotations (v1):

    annotations:
      ad.datadoghq.com/mycontainer-dragonfly.check_names: '["openmetrics"]'
      ad.datadoghq.com/mycontainer-dragonfly.init_configs: '[{}]'
      ad.datadoghq.com/mycontainer-dragonfly.instances: '[{
          "prometheus_url": "http://%%host%%:6379/metrics",
          "namespace": "dragonflydb",
          "metrics": ["*"]
          }]'
Pothulapati commented 1 year ago

@hermanbanken Ah, We can have a way to pass annotations into the Dragonfly pod! This shouldn't be hard. Just adding an annotations field into the CRD and passing that into the Statefulset spec.

hermanbanken commented 1 year ago

@Pothulapati that would be great!

Pothulapati commented 9 months ago

Fixed with https://github.com/dragonflydb/dragonfly-operator/pull/101 https://github.com/dragonflydb/dragonfly-operator/pull/113