search

dragonflydb / dragonfly-operator

A Kubernetes operator to install and manage Dragonfly instances.
https://www.dragonflydb.io/docs/managing-dragonfly/operator/installation
Apache License 2.0
144 stars 34 forks source link

Manifest in release v0.0.5 contains v0.0.4 image tag #74

Closed marnixbouhuis closed 11 months ago

marnixbouhuis commented 1 year ago

The v0.0.5 release contains the wrong image tag inside the manifests/dragonfly-operator.yaml file.

When viewing the file as in tag v0.0.5 (https://github.com/dragonflydb/dragonfly-operator/blob/v0.0.5/manifests/dragonfly-operator.yaml#L463) the following shows: https://github.com/dragonflydb/dragonfly-operator/blob/f4cc58c3d7a7bd3d84d021e615ec0041c886ecd1/manifests/dragonfly-operator.yaml#L463

Pothulapati commented 1 year ago

Hey @MarnixBouhuis, Thanks for raising the issue.

Actually, The plan for manifests was to have the latest image manifests available that folks could use from the repo, and not tie it per commit (like you are expecting). This is why we also didn't release these as part of the release Github artifacts.

But, I agree with your expectation here and I will make it so that we update the manifests as a release process step from the next release.

Pothulapati commented 11 months ago

So, We strarted following this pattern and the last two releases (atleast) have the matching versions in the files. So, Closing this.