search

dragonflydb / dragonfly-operator

A Kubernetes operator to install and manage Dragonfly instances.
https://www.dragonflydb.io/docs/managing-dragonfly/operator/installation
Apache License 2.0
144 stars 34 forks source link

feat(resources): Add ability to set Annotations, Affinity and Tolerations #76

Closed TheMerski closed 1 year ago

TheMerski commented 1 year ago

We are running the dragonfly operator in our clusters, and missed some configuration options we would like for the Dragonfly pods.

I added Annotations which allows adding annotations. We use datadog Autodiscovery which works based on these annotations.

I also added Tolerations and Affinity options so we can configure on which nodes the pods run.

TheMerski commented 1 year ago

Thanks for working on this! Will test and update my findings. Left a comment meanwhile.

Great, thanks for taking a look so fast! It is my first time working on it so please let me know if there is something I need to change or update.

Pothulapati commented 1 year ago

@TheMerski Sorry for the late get back but the change looks good! Can you also remove the changes in the manifest/crd.yaml? (Same reason as above. should have mentioned it earlier).

Once the CI passes, I will go ahead and merge it! :) Will probably do a Operator release this week to ship this change!

TheMerski commented 1 year ago

@TheMerski Sorry for the late get back but the change looks good! Can you also remove the changes in the manifest/crd.yaml? (Same reason as above. should have mentioned it earlier).

Once the CI passes, I will go ahead and merge it! :) Will probably do a Operator release this week to ship this change!

No problem, I have also removed the crd.yaml file now.

It would be great if the new operator release can also contain at least dragonflydb v1.4.0 since we have been running these changes with v1.4.0 and noticed a massive latency decrease with v1.4.0.

Pothulapati commented 1 year ago

It would be great if the new operator release can also contain at least dragonflydb v1.4.0 since we have been running these changes with v1.4.0 and noticed a massive latency decrease with v1.4.0.

For sure! We will make sure to do that! :) Thanks again for the pull request.