search

dragonflydb / dragonfly-operator

A Kubernetes operator to install and manage Dragonfly instances.
https://www.dragonflydb.io/docs/managing-dragonfly/operator/installation
Apache License 2.0
144 stars 34 forks source link

Support for nodeSelector and also custom pod labels and annotations #80

Closed jim12321 closed 9 months ago

jim12321 commented 1 year ago

Would love if this supported defining nodeSelector (not using the affinity method).

Also to have custom pod labels and annotations.

Thanks.

Pothulapati commented 1 year ago

Hey @jim12321,

A valid request for direct node selectors, instead of affinities and for labels.

Btw, We already support adding annotations: https://github.com/dragonflydb/dragonfly-operator/blob/main/api/v1alpha1/dragonfly_types.go#L47

jim12321 commented 1 year ago

Cool. Thanks for the link. Would love to use but want to wait for node selector support. :D

scog commented 1 year ago

Cool. Thanks for the link. Would love to use but want to wait for node selector support. :D

Same. Would be great to have nodeSelector support implemented!

Pothulapati commented 11 months ago

Considering that nodeAffinity can do the same task, Adding nodeSelector is not a priority but feel free to raise a PR and we are more than happy to help you get it merged!