search

dragonflydb / dragonfly-operator

A Kubernetes operator to install and manage Dragonfly instances.
https://www.dragonflydb.io/docs/managing-dragonfly/operator/installation
Apache License 2.0
132 stars 28 forks source link

feat(resources): Updated the CRD to support setting environment variables and a service account #87

Closed pstewy closed 1 year ago

pstewy commented 1 year ago

In order to get authentication working, the operator needed to be updated to communicate with the pods using their configured passwords. I also added support for setting an environment variable and service account, which allows for different methods of setting the password. I believe this satisfies some of the requests in https://github.com/dragonflydb/dragonfly-operator/issues/50

EDIT: since https://github.com/dragonflydb/dragonfly-operator/commit/4465e8082c05fafc34a3f029adba25a1ba8b4ad8, this PR does not modify how the operator communicates with pods.

jhutchins commented 1 year ago

This looks great. We could really use something like this.

Abhra303 commented 1 year ago

The commit message doesn't have a header. Please use the PR title (without the trailing dot) as the commit message header. Also, the message description seems to have an indent on each line.

pstewy commented 1 year ago

Hey @Abhra303 , thank you for accepting the pull request and for the prompt responses! Sorry if I missed this in the documentation, but what is the release process for the operator? I'd love to use the new image with these changes.

Abhra303 commented 1 year ago

Hi @pstewy, a new Dragonfly version will be released soon (most probably this week). We will do a new release along with it.