search

dragonflydb / dragonfly

A modern replacement for Redis and Memcached
https://www.dragonflydb.io/
Other
25.29k stars 910 forks source link

Check slot id on config set is less then Max slot #1322

Closed adiholden closed 1 year ago

chakaz commented 1 year ago

Is this not what we do here?

https://github.com/dragonflydb/dragonfly/blob/e5b5e35e55424df3c70a7d6db5b1fc68395ef611/src/server/cluster/cluster_config.cc#L82

I see that we don't have a unit test for that, I can and should add one.

adiholden commented 1 year ago

Oh sorry, it was not clear from the code. I was looking for comparison to kMaxSlotNum. Will close the issue