search

dragonflydb / dragonfly

A modern replacement for Redis and Memcached
https://www.dragonflydb.io/
Other
25.8k stars 950 forks source link

crash during connection migrate #1960

Closed romange closed 1 year ago

romange commented 1 year ago

following https://github.com/romange/helio/pull/148

F20230927 13:30:50.966094 23574 uring_socket.cc:381] Check failed: error_cb_id_ == (4294967295U) 
*** Check failure stack trace: ***
    @     0x559ebce74c1f  google::LogMessage::Fail()
    @     0x559ebce74b66  google::LogMessage::SendToLog()
    @     0x559ebce7435b  google::LogMessage::Flush()
    @     0x559ebce78072  google::LogMessageFatal::~LogMessageFatal()
    @     0x559ebce00c2a  util::fb2::UringSocket::RegisterOnErrorCb()
    @     0x559ebc9bfcde  facade::Connection::OnPostMigrateThread()
    @     0x559ebccd0b00  util::ListenerInterface::Migrate()
    @     0x559ebc9d5e75  facade::Connection::Migrate()
    @     0x559ebc013aaf  dfly::DflyCmd::Flow()
    @     0x559ebc010a75  dfly::DflyCmd::Run()
    @     0x559ebbb4ed9f  dfly::ServerFamily::Dfly()
    @     0x559ebbb19f8d
romange commented 1 year ago

full log: https://github.com/dragonflydb/dragonfly/actions/runs/6326295832/job/17179558036#step:10:564

romange commented 1 year ago

@dranikpg can you please link the PR here?

dranikpg commented 1 year ago

I might assume this fixed it https://github.com/dragonflydb/dragonfly/pull/1940/commits/d23e1f786eb89379c1d1aa0baea9d08dfd16be84