dragonflydb / dragonfly

A modern replacement for Redis and Memcached
https://www.dragonflydb.io/
Other
25.97k stars 955 forks source link

allow server resurrection after repltakeover #2860

Open romange opened 7 months ago

romange commented 7 months ago

Today a dragonfly master shutdown upon successful repltkeover flow.

@ashotland suggests that instead dragonfly will stop accepting connections on the main port and will close all the existing connections.

It will still be possible to revert this operation via the admin port by allowing the connection to connect to the main port.

romange commented 7 months ago

I appreciate some of the advantages of FAILOVER design:

  1. It allows aborting the failover operation if needed
  2. It keeps the master data by transforming the master to replica in case of the successful takeover.
  3. it allows a forceful failover, with some data loss but may still be very useful if master does not succeed to failover using the usual path.

For more details, see https://github.com/redis/redis/pull/8315