dragonflydb / dragonfly

A modern replacement for Redis and Memcached
https://www.dragonflydb.io/
Other
24.46k stars 884 forks source link

fix: replicaof_reject_on_load flake #3203

Closed kostasrim closed 6 days ago

kostasrim commented 1 week ago

The bug is that by the time we issue a REPLICA OF command dragonfly might finish loading the snapshot triggering a false positive assertion later on. I increased the snapshot size to provide a smaller window for this issue as I would not like to relax the contstrains.

Furthermore, the reason that some of the logs did not exist in the failed log files is that assertions in pytest kill the process bypassing the SIGTERM handlers we defined (and consequently loose some portion of the logs)