chore: change replica connect error log to WARN

dragonflydb / dragonfly

A modern replacement for Redis and Memcached

https://www.dragonflydb.io/

Other

25.42k stars 919 forks source link

chore: change replica connect error log to WARN #3214

Closed romange closed 2 months ago

romange commented 3 months ago

Context: reduce noise when performing H/A datastore update because we get spurious errors. We identify the disconnect event with metrics (by looking at master lag).

adiholden commented 3 months ago

@romange how would you track multiple disconnect events on replication? if you have some kind of a bug in replication that causes replica to reconnect again and again. we have 0 lag in full sync mode

romange commented 3 months ago

True. In that case I would like the team to take over this PR and add the metric. Also maybe fix https://github.com/dragonflydb/dragonfly/issues/3210 while we are at it.

adiholden commented 3 months ago

https://github.com/dragonflydb/dragonfly/issues/3215