There is also a separate issue with compression. Previously, we only called FlushToSink in SaveEpilogue and before SaveBody (to flush previous entries). However, with the current changes, we call FlushToSink when we serialize X number of bytes. This doesn't work with the protocol implemented in rdb_load because we now split let's say a list in multiple chunks and LoadKeyValue on RdbLoader expects to read a string (for the values) but it gets a compressed blob and fails with unrecognized rdb type. I created this separate issue for that: #3324
Resolves #3223
There is also a separate issue with
compression
. Previously, we only calledFlushToSink
inSaveEpilogue
and beforeSaveBody
(to flush previous entries). However, with the current changes, we callFlushToSink
when we serialize X number of bytes. This doesn't work with the protocol implemented inrdb_load
because we now split let's say a list in multiple chunks andLoadKeyValue
onRdbLoader
expects to read a string (for the values) but it gets acompressed blob
and fails with unrecognized rdb type. I created this separate issue for that: #3324