dragonflydb / dragonfly

A modern replacement for Redis and Memcached
https://www.dragonflydb.io/
Other
25.93k stars 951 forks source link

Support for dump command required in order to support rep.app in dragonflydb #343

Closed boazsade closed 2 years ago

boazsade commented 2 years ago

Describe the bug Trying to rename a key using the resp.app fail. The root cause is that the sequence in which the rename is running using the application require the support of the dump command (see bellow), which is not yet supported, The dump command is currently not supported, this is required in order to support the rename key in resp.app application the details of this execution This is taken from dragonfly log:

type oldkey ttl oldkey get oldkey dump oldkey (this is were it breaks) RESTORE newkey 0 "value from the dump" (only with redis where it works) DEL oldkey (only with redis where it works)

To Reproduce Steps to reproduce the behavior:

open resp.pp press on the connection and connect if you don't have any key press the "add new key" on any of the listed databases and create key with string value. select a key on the new window select "rename" try to set new name - an error message "Dump is not supported" will pop up. Expected behavior Being able to rename the key as it is with the connection to redis.

Environment (please complete the following information):

OS: [ubuntu 20.04] Kernel:Linux dfly2 5.15.0-47-generic #51-Ubuntu SMP Thu Aug 11 07:51:15 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux Containerized?: Bare Metal Dragonfly Version: 0.8.0

Additional context DUMP is not supported per API status, however to be able to use this application we will need to be able to support this.

boazsade commented 2 years ago

It seems that in order for the "rename key" to work on resp.app the command "restore" need to be added as well