dragonflydb / dragonfly

A modern replacement for Redis and Memcached
https://www.dragonflydb.io/
Other
25.87k stars 948 forks source link

Config rewrite support #3787

Open boomballa opened 1 month ago

boomballa commented 1 month ago

Did you search GitHub Issues and GitHub Discussions First?

2511

Seeing that someone previously suggested support for the config rewrite command, but didn't elaborate on the reasoning, I'd like to give my own personal opinion.

Is your feature request related to a problem? Please describe. Recently, I've been organizing the scripts and data output related to dragonfly monitoring, and I've seen the official monitoring based on Prometheus and Grafana before, but I feel that the monitoring items are a bit less than enough to support the monitoring needs of the production environment, so I'd like to do more monitoring data extraction. This time there a places I want to propose, let's communicate together to see if there is a need to improve.

We will treat configuration inconsistency as a case to assist the DBA in targeting the management of cached instances. image In this case, it is normally necessary to alert the DBA to warn them.

Additional context I'm sorry I'm here to raise requirements again, hahaha, these requirements are trying to usability and reliability after using our dragonfly on-line to the production environment, I hope dragonfly is getting better and better, looking forward to the reply, together to discuss. 😃

romange commented 1 month ago

@boomballa thanks for suggesting these features. Can you please open a "process_id" issue separately and copy paste there what you wrote here? These features require a different effort, so better to separate.

boomballa commented 1 month ago

@romange Okay, I'll take care of it right away.

boomballa commented 1 month ago

@romange Okay, I'll take care of it right away.

I've separated the two issues, tough.