search

dragonflydb / dragonfly

A modern replacement for Redis and Memcached
https://www.dragonflydb.io/
Other
25.96k stars 954 forks source link

chore: remove DbSlice mutex and add ConditionFlag in SliceSnapshot #4073

Open kostasrim opened 2 weeks ago

kostasrim commented 2 weeks ago

Partially solves #4072

kostasrim commented 2 weeks ago

https://github.com/dragonflydb/dragonfly/actions/runs/11705220823

adiholden commented 1 week ago

It will be best if you add statistics for big value serilization i.e preept in serialize expose in stats This way we will know this logic is executed in pytest flows and track this in running dragonfly servers

kostasrim commented 1 week ago

It will be best if you add statistics for big value serilization i.e preept in serialize expose in stats This way we will know this logic is executed in pytest flows and track this in running dragonfly servers

Generally this PR is about removing the lock from db slice and not adding statistics. I am happy to do this as part of this PR as it's a straightforward change but usually I like to separate tasks like that