search

dragonflydb / dragonfly

A modern replacement for Redis and Memcached
https://www.dragonflydb.io/
Other
25.96k stars 954 forks source link

fix server: fix write to slowlog on squashing flow #4138

Closed adiholden closed 4 days ago

adiholden commented 5 days ago

The bug: slow invocations where not written to slowlog The fix: extract the relevant connection pointer from context on squashing

romange commented 4 days ago

how it affects slow invocations? in other words why conn pointer is relevant to slowlog?

adiholden commented 4 days ago

how it affects slow invocations? in other words why conn pointer is relevant to slowlog?

we have this condition conn != nullptr in which we do not enter the slowlog checks if conn is null. But I cant tell which flows have conn = nullptr