fix: test_replication_all failure

dragonflydb / dragonfly

A modern replacement for Redis and Memcached

https://www.dragonflydb.io/

Other

25.96k stars 954 forks source link

fix: test_replication_all failure #4155

Closed romange closed 1 day ago

romange commented 2 days ago

Fixes #4150. The failure can be reproduced with high probability on ARM via pytest dragonfly/replication_test.py -k test_replication_all[df_factory0-mode0-8-t_replicas3-seeder_config3-2000-False]

Not sure why this barrier is needed but #4146 removes the barrier which breaks a gentle balance in the code in unexpected way.

romange commented 2 days ago

Regression tests pass: https://github.com/dragonflydb/dragonfly/actions/runs/11922091966