search

dragonflydb / dragonfly

A modern replacement for Redis and Memcached
https://www.dragonflydb.io/
Other
25.96k stars 954 forks source link

Some dashboard panel selectors missing #4164

Open applike-ss opened 19 hours ago

applike-ss commented 19 hours ago

Describe the bug The following panels are missing any selector, which makes the dashboard consider dragonfly instances from other namespaces:

To Reproduce Steps to reproduce the behavior:

  1. Deploy multiple dragonfly instances (different namespaces)
  2. Deploy a prometheus + grafana
  3. Add a monitor to fetch the metrics
  4. Install Dashboard from repo
  5. Check panels

Expected behavior I should not see metrics from different namespaces, as those must by definiton be a different cluster.

Would be nice to have dragonfly clusters emit a label cluster which would be used to select metrics of a specific cluster. That would make having multiple clusters in the same namespace possible too.

Screenshots image

romange commented 19 hours ago

Hi, thanks for filing the issue. Can you send a pr, please?

applike-ss commented 19 hours ago

I'd fix the dashboard, which selectors do you find fitting? Should the advanced metrics panel group also filter based on the instance label?

To me it would be more usable if i could see the metrics of all pods of the same cluster at the same time.

What do you think?

romange commented 19 hours ago

Where do you take this dashboard, actually? Is it from https://github.com/dragonflydb/dragonfly/tree/main/tools/local/monitoring ?

applike-ss commented 19 hours ago

yes, that is the one

romange commented 19 hours ago

So this one it totally for the community to decide. I mainly use it for local development, so I do not have strong opinions.

romange commented 19 hours ago

@Pothulapati , @Abhra303 - what do you think?

applike-ss commented 18 hours ago

pls check it out if you are interested: https://github.com/dragonflydb/dragonfly/pull/4165/files