fannyfan414
commented
1 year ago Maybe problem here (vendor/laravel/horizon/src/RedisQueue.php)
migrateExpiredJobs with redis return empty array, but dragonfly return false
public function migrateExpiredJobs($from, $to)
{
return $this->getConnection()->eval(
LuaScripts::migrateExpiredJobs(), 3, $from, $to, $to.':notify', $this->currentTime(), $this->migrationBatchSize
);
}migrateExpiredJobs method fron LuaScripts:
public static function migrateExpiredJobs()
{
return <<<'LUA'
-- Get all of the jobs with an expired "score"...
local val = redis.call('zrangebyscore', KEYS[1], '-inf', ARGV[1], 'limit', 0, ARGV[2])
-- If we have values in the array, we will remove them from the first queue
-- and add them onto the destination queue in chunks of 100, which moves
-- all of the appropriate jobs onto the destination queue very safely.
if(next(val) ~= nil) then
redis.call('zremrangebyrank', KEYS[1], 0, #val - 1)
for i = 1, #val, 100 do
redis.call('rpush', KEYS[2], unpack(val, i, math.min(i+99, #val)))
-- Push a notification for every job that was migrated...
for j = i, math.min(i+99, #val) do
redis.call('rpush', KEYS[3], 1)
end
end
end
return val
LUA;
}
romange
dranikpg
Describe the bug Hey! I created a simple application with laravel horizon and try to use it with dragonflydb as queue-driver. Currently it's working with redis 6.2.6 or keydb 6.3.1.
I have 2 containers -
app_laravelandapp_laravel_horizon. First is simple api, with GET route/api/testthat pushTestJobjob to queue and thenapp_laravel_horizonworkers process this job.To Reproduce
docker network create app_test_networkapp_laravel,app_laravel_horizon, andredis_masterwith passwordredistestpassworddocker compose -f ./docker-compose.yml upExpected behavior
http://127.0.0.1:8000/horizonand check that horizon status is Active.http://127.0.0.1:8000/api/testor run commanddocker run --rm --net=app_test_network ghcr.io/six-ddc/plow http://app_laravel:8000/api/test -c 1 -d 1shttp://127.0.0.1:8000/horizon/jobs/completedand see that jobs are completed.redis-cli -a redistestpasswordandzrange laravel_horizon:completed_jobs 0 -1to see completed jobs.dragonflyall jobs for some reasong hang up inpendingstate and never started..Screenshots Using
redis:Using
dragonflydb:Environment (please complete the following information):