dragonflyoss / Dragonfly2

Dragonfly is an open source P2P-based file distribution and image acceleration system. It is hosted by the Cloud Native Computing Foundation (CNCF) as an Incubating Level Project.
https://d7y.io
Apache License 2.0
2.3k stars 293 forks source link

feat: add DefaultFilteredQueryParams for job #3608

Closed gaius-qi closed 1 month ago

gaius-qi commented 1 month ago

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 35.68%. Comparing base (5a51a61) to head (6f952e7). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/service/job.go 0.00% 9 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dragonflyoss/Dragonfly2/pull/3608/graphs/tree.svg?width=650&height=150&src=pr&token=PUICJYSAT7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dragonflyoss)](https://app.codecov.io/gh/dragonflyoss/Dragonfly2/pull/3608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dragonflyoss) ```diff @@ Coverage Diff @@ ## main #3608 +/- ## ========================================== - Coverage 35.71% 35.68% -0.04% ========================================== Files 339 335 -4 Lines 37326 37294 -32 ========================================== - Hits 13332 13309 -23 + Misses 23151 23144 -7 + Partials 843 841 -2 ``` | [Flag](https://app.codecov.io/gh/dragonflyoss/Dragonfly2/pull/3608/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dragonflyoss) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dragonflyoss/Dragonfly2/pull/3608/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dragonflyoss) | `35.68% <40.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dragonflyoss#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/dragonflyoss/Dragonfly2/pull/3608?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dragonflyoss) | Coverage Δ | | |---|---|---| | [api/manager/docs.go](https://app.codecov.io/gh/dragonflyoss/Dragonfly2/pull/3608?src=pr&el=tree&filepath=api%2Fmanager%2Fdocs.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dragonflyoss#diff-YXBpL21hbmFnZXIvZG9jcy5nbw==) | `0.00% <ø> (ø)` | | | [pkg/strings/strings.go](https://app.codecov.io/gh/dragonflyoss/Dragonfly2/pull/3608?src=pr&el=tree&filepath=pkg%2Fstrings%2Fstrings.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dragonflyoss#diff-cGtnL3N0cmluZ3Mvc3RyaW5ncy5nbw==) | `100.00% <100.00%> (ø)` | | | [manager/service/job.go](https://app.codecov.io/gh/dragonflyoss/Dragonfly2/pull/3608?src=pr&el=tree&filepath=manager%2Fservice%2Fjob.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dragonflyoss#diff-bWFuYWdlci9zZXJ2aWNlL2pvYi5nbw==) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/dragonflyoss/Dragonfly2/pull/3608/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dragonflyoss)