Closed SToPire closed 2 months ago
As it may break the existing usage of nydus-image unpack
, I hope to take more advices for this PR. Then I will add the corresponding tests and update the doc.
Attention: Patch coverage is 0%
with 157 lines
in your changes missing coverage. Please review.
Project coverage is 61.28%. Comparing base (
3eb5c7b
) to head (4ad1e46
). Report is 3 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
src/bin/nydus-image/main.rs | 0.00% | 110 Missing :warning: |
storage/src/factory.rs | 0.00% | 47 Missing :warning: |
Since unpack and compact subcommands does not need the entire nydusd configuration file, let's refactor their cli interface and directly take backend configuration file.
Specifically, we introduce
--backend-type
,--backend-config
and--backend-config-file
options to specify the backend type and remove--config
option.Fixes: #1602
Relevant Issue (if applicable)
1602
Details
Introduce
--backend-type
,--backend-config
and--backend-config-file
options forunpack
andcompact
subcommands in nydus-image.Types of changes
Checklist