search

dragonfruitnetwork / dragon6-api

Rainbow Six Siege Stats API for .NET
Apache License 2.0
12 stars 6 forks source link

Improve recognition of modern stats that are ratios or whole values #304

Closed aspriddell closed 2 years ago

aspriddell commented 2 years ago

Currently, RoundsWithAnAce is a ratio of aces to rounds, and as such needs to be multipled by the total rounds to get a meaningful value. Converting the property to a container that is created during deserialization can allow for the proportion and the raw value people will want to be served.

JsonProperty ordering will need to be used to ensure the rounds object is parsed first.

aspriddell commented 2 years ago

reopening as the pr didn't do what it was expected. It might be a better idea to create the jsonextensions and compute these values, as ordering isn't for deserialization...

aspriddell commented 2 years ago

closing as can be differentiated by ratios having float values, and could always leave a notice on the wiki if needed