This finally makes the entire token fetching flow asynchronous, with almost no additional pressure when pulling it from the cache, thanks to ValueTasks and being able to hide the OnExecutingAsync() methods is also a bonus.
Only breaking change is the RequestAccessToken now returns a ValueTask<IUbisoftToken>, which means the method needs to be made async, which shouldn't be an issue.
Extra TODOs
[ ] update the wiki
[ ] consider if locking should have a timeout attached
This finally makes the entire token fetching flow asynchronous, with almost no additional pressure when pulling it from the cache, thanks to
ValueTask
s and being able to hide theOnExecutingAsync()
methods is also a bonus.Only breaking change is the
RequestAccessToken
now returns aValueTask<IUbisoftToken>
, which means the method needs to be made async, which shouldn't be an issue.Extra TODOs