search

dragonmantank / cron-expression

CRON for PHP: Calculate the next or previous run date and determine if a CRON expression is due
MIT License
4.57k stars 124 forks source link

Change private variables to protected #106

Closed DerekCresswell closed 3 years ago

DerekCresswell commented 3 years ago

This allows extending classes to access the order for parts the same way as the base class.

This introduces no breaking changes. Could be introduced as a patch release.

DerekCresswell commented 3 years ago

In fact, all of the internal variables should be protected to allow for proper usage.

dragonmantank commented 3 years ago

That's fine, I generally prefer protected anyway in libraries. If you want to extend the PR to cover everything that's a +1 from me.

DerekCresswell commented 3 years ago

That's fine, I generally prefer protected anyway in libraries. If you want to extend the PR to cover everything that's a +1 from me.

Donezo!

DerekCresswell commented 3 years ago

Bump : )