Fixed backward incompatible change in php8.2

dragonmantank / cron-expression

CRON for PHP: Calculate the next or previous run date and determine if a CRON expression is due

MIT License

4.55k stars 121 forks source link

Fixed backward incompatible change in php8.2 #174

Open SeynovAM opened 6 months ago

SeynovAM commented 6 months ago

php8.2 has backward incompatible: number symbols in relative formats no longer accept multiple signs, e.g. +-2.

https://www.php.net/manual/en/migration82.incompatible.php

dragonmantank commented 5 months ago

This discussion and PR actually caused me to go down another path, which seemed to end up being that modify() is a bad method to be using. There is a fix that I believe fixes a number of bugs, but would like some feedback on.

Before I release a fix, could I get your thoughts on https://github.com/dragonmantank/cron-expression/discussions/181 as it will impact the overall solution?