search

dragonpilot-community / dp-devel

Development branch for dragonpilot
MIT License
31 stars 29 forks source link

MDPS for Hyundai is gone #50

Closed jcwlim closed 1 year ago

jcwlim commented 1 year ago

Describe the bug

Hi, I notice the MDPS harness support for Hyundai is gone. I check the changes log, it was missing. Is it possible to add it back? I know Panda need to do some code change but I don't really sure where to start.

Provide a route where the issue occurs

ed2f9244

openpilot version

release2_e2e

Additional info

No response

jcwlim commented 1 year ago

Possible to add in the support? As I study from the code, I just need to change a line in the car interface.py to enable the support to steel down to zero. However, the problem is that panda need to do some forwarding for Hyundai which I don't have access to it now.

eFiniLan commented 1 year ago

can you provide a PR?

We will add a toggle to support this.

jcwlim commented 1 year ago

So sorry, I can't provide a PR because your beta 2 code is private mode right? I just know where is the place to enable steel down to zero but panda need to customise too.

rav4kumar commented 1 year ago

So sorry, I can't provide a PR because your beta 2 code is private mode right? I just know where is the place to enable steel down to zero but panda need to customise too.

https://github.com/dragonpilot-community/panda/tree/master2

jcwlim commented 1 year ago

@rav4kumar , may I know how do I compile the panda file for my EON? I had done some code changes and would like to try if it is working.

eFiniLan commented 1 year ago

@jcwlim do you want to take a look https://github.com/dragonpilot-community/panda/tree/lpdp and create a PR against it?

I'm not sure if MDPS is allowed by comma.ai though.

jcwlim commented 1 year ago

@eFiniLan ,thanks. Yes, legacy MDPS is not allow from comma.ai Besides that, I notice the latest lp-dp-beta2 bring back the toggle for SmartMDPS which already solved the problem. I will close this ticket. Thanks.