dragonresearch / rpki.net

Dragon Research Labs rpki.net RPKI toolkit
54 stars 30 forks source link

rtr-origin bugreport #35

Closed sraustein closed 13 years ago

sraustein commented 13 years ago

{{{ Hi Rob,

I'm working currently on an RPKI-RTR client library and I'm using your rcynic + rtr-origin (SVN rev: r3957) tools for testing.

Today I discovered a bug in rtr-origin. My client sent an error PDU and rtr-origin terminated with the following error:

Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: [reset_query] Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: Traceback (most recent call last): Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: File "/usr/lib/python2.6/asyncore.py", line 78, in read Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: obj.handle_read_event() Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: File "/usr/lib/python2.6/asyncore.py", line 428, in handle_read_event Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: self.handle_read() Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: File "/usr/lib/python2.6/asynchat.py", line 140, in handle_read Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: self.found_terminator() Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: File "/usr/local/bin/rtr-origin", line 947, in found_terminator Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: self.deliver_pdu(p) Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: File "/usr/local/bin/rtr-origin", line 1078, in deliver_pdu Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: pdu.serve(self) Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: AttributeError: 'error_report' object has no attribute 'serve' Aug 24 17:03:11 debian rtr-origin/server/tcp/85.176.140.78: 58290[14491]: [Exiting after unhandled exception]

The error_report class seems to miss the serve(..) method.

BTW exists a public bugtracker for your RTR tools where I could report bugs (if I will find any :-))?

best regards

Fabian

}}}

[attachment:"signature.asc"]

_Trac ticket #36 component rtrorigin priority minor, owner sra, created by mail@fholler.de on 2011-08-24T16:14:56Z, last modified 2011-08-25T17:34:28Z

sraustein commented 13 years ago

signature.asc Added by email2trac Trac attachment by mail@fholler.de on 2011-08-25T17:34:28Z

sraustein commented 13 years ago

Attempted fix checked in as r3961, please test and let me know if this solved the problem.

Trac comment by sra on 2011-08-24T16:59:33Z

sraustein commented 13 years ago

Reporter has tested fix and says it works for him.

Trac comment by sra on 2011-08-25T17:34:28Z

sraustein commented 13 years ago

Closed with resolution fixed